Fix bugs in verdi process watch
#3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of the callback function did not define the `communicator` causing an exception to be thrown. The callback function is improved to make the formatted messages easier to read. The main command also has extra information message echoed to explain to the user how to interrupt the command. Finally, the usage of a `Future` to block the thread indefinitely has been replaced by a simple while loop calling `sleep` because the future was swallowing the keyboard interrupt, making it impossible to exit from the command that way.
zhubonan
approved these changes
Aug 16, 2019
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Sep 30, 2019
The signature of the callback function did not define the `communicator` causing an exception to be thrown. The callback function is improved to make the formatted messages easier to read. The main command also has extra information message echoed to explain to the user how to interrupt the command. Finally, the usage of a `Future` to block the thread indefinitely has been replaced by a simple while loop calling `sleep` because the future was swallowing the keyboard interrupt, making it impossible to exit from the command that way.
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Oct 16, 2019
The signature of the callback function did not define the `communicator` causing an exception to be thrown. The callback function is improved to make the formatted messages easier to read. The main command also has extra information message echoed to explain to the user how to interrupt the command. Finally, the usage of a `Future` to block the thread indefinitely has been replaced by a simple while loop calling `sleep` because the future was swallowing the keyboard interrupt, making it impossible to exit from the command that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3128
The signature of the callback function did not define the
communicatorcausing an exception to be thrown. The callback function is improved to
make the formatted messages easier to read. The main command also has
extra information message echoed to explain to the user how to interrupt
the command. Finally, the usage of a
Futureto block the threadindefinitely has been replaced by a simple while loop calling
sleepbecause the future was swallowing the keyboard interrupt, making it
impossible to exit from the command that way.