Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete unregisteration Memory Leak #198

Closed
SupaHam opened this Issue Mar 4, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@SupaHam
Copy link

commented Mar 4, 2019

As per chat on #acf discord 2019-03-04.

https://github.com/aikar/commands/blob/master/bukkit/src/main/java/co/aikar/commands/BukkitCommandManager.java#L240
GitHub
aikar/commands

[17:43] Aikar: prob just need to clear registeredCommands after that
[17:45] Aikar: and unset the RootCommand ref```

JanTuck added a commit to JanTuck/commands that referenced this issue Apr 14, 2019

Issue aikar#198
I just did exactly as you said to do in the referenced issue.

Removed command from registeredCommands on unregisterCommand

JanTuck added a commit to JanTuck/commands that referenced this issue Apr 14, 2019

Issue aikar#198
I just did exactly as you said to do in the referenced issue.

Removed command from registeredCommands on unregisterCommand

@JanTuck JanTuck referenced this issue Apr 14, 2019

Merged

#198 #208

@aikar aikar closed this in 4880a02 Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.