Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username too short needed? #226

Closed
baticag opened this issue Jul 22, 2019 · 6 comments

Comments

@baticag
Copy link

commented Jul 22, 2019

I am using SkinsRestorer and they are using your library for their commands.

Why do you check minimum length of player's name since I have players that are named only with 2 letter names, for example: "ez"?

Because of that check commands fail to execute and I cannot set skin to that player.
Can you please check that or make it configurable?

@chickeneer

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

I will look into that - give me a bit to pull the code.
Do you mind checking if ez_ works. Will still look into it, just getting a strange recollection that might work.

@baticag

This comment has been minimized.

Copy link
Author

commented Jul 22, 2019

Don't think that usernames lower than 3 characters work, like it is set on this line for BungeeCord

chickeneer added a commit that referenced this issue Jul 22, 2019

@baticag

This comment has been minimized.

Copy link
Author

commented Jul 22, 2019

I think that this new commit still doesn't allow nickname "ez"

@chickeneer

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

I have deployed a fix for this issue. The author of SkinsRestorer will need to release an update to their code to make it work.

Could you explain? "ez" is definitely not shorter than 2 characters.

@chickeneer chickeneer closed this Jul 22, 2019

@baticag

This comment has been minimized.

Copy link
Author

commented Jul 22, 2019

Yeah my mistake sorry, you are right, thank you very much for fix! :)

@chickeneer

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

No worries. It was actually something that was fixed for the Bukkit implementation already. Not all fixes have propagated to the other implementations.
#133
That issue would indicate I should drop the length check entirely.

chickeneer added a commit that referenced this issue Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.