New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop trivial Guava usages #142

Merged
merged 7 commits into from Jul 19, 2018

Conversation

2 participants
@osipxd
Contributor

osipxd commented Jun 18, 2018

@aikar
Please check that I did it right.

Relates to #120, #127

@aikar

overall looks good.

@@ -65,9 +63,6 @@ public void onAsyncTabComplete(AsyncTabCompleteEvent event) {
BukkitCommandIssuer issuer = this.manager.getCommandIssuer(event.getSender());
List<String> results = cmd.tabComplete(issuer, commandLabel, args, true);
if (event.getCompletions() instanceof ImmutableList) {

This comment has been minimized.

@aikar

aikar Jun 18, 2018

Owner

Same issue occurs here, just needs to be the java version check now instead. If it returned immutable, we need to rebuild as mutable.

This comment has been minimized.

@osipxd

osipxd Jun 19, 2018

Contributor

FIxed

osipxd added some commits Jun 18, 2018

Auto reformat
Removed extra imports
Added final modifiers to constants
Removed public modifier from interfaces
Removed Guava Sets
Finally closes #120
@aikar

aikar approved these changes Jul 19, 2018

@aikar aikar merged commit 3c979a9 into aikar:master Jul 19, 2018

@osipxd osipxd deleted the osipxd:feature/dropGuava branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment