New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unregister method for JDA #174

Merged
merged 2 commits into from Oct 23, 2018

Conversation

2 participants
@simpleauthority
Contributor

simpleauthority commented Sep 20, 2018

This PR is to allow users to unregister commands from the JDACommandManager

Currently slightly flawed, needs research. When re-registering it spits out a load of messages like so:

SEVERE: [ACF] ACF Error: settings registered subcommand boss role for root command settings - but it is already defined in settings
Sep 20, 2018 3:58:31 AM com.algorithmjunkie.freelance.gachapon.acf.JDACommandManager log
SEVERE: [ACF] 2 subcommands of the same prefix may not be spread over 2 different classes. Ignoring this.

Not sure if this is just for me, or if it's for all.

@simpleauthority

This comment has been minimized.

Contributor

simpleauthority commented Oct 3, 2018

I'm dumb and lazy I'll finish this soon.

@simpleauthority

This comment has been minimized.

Contributor

simpleauthority commented Oct 13, 2018

@aikar This works and does not show any errors.

@aikar

aikar approved these changes Oct 23, 2018

@aikar aikar merged commit aa6fa28 into aikar:master Oct 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment