Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic JUnit5 testing framework. #202

Merged
merged 1 commit into from Mar 23, 2019

Conversation

Projects
None yet
3 participants
@dumptruckman
Copy link
Contributor

commented Mar 17, 2019

No description provided.

@MiniDigger
Copy link
Contributor

left a comment

minor nitpick, other than that it looks good


public void unregisterCommand(BaseCommand command) {
for (Map.Entry<String, RootCommand> entry : command.registeredCommands.entrySet()) {
String jdaCommandName = entry.getKey().toLowerCase();

This comment has been minimized.

Copy link
@MiniDigger

MiniDigger Mar 18, 2019

Contributor
Suggested change
String jdaCommandName = entry.getKey().toLowerCase();
String commandName = entry.getKey().toLowerCase();
public void unregisterCommand(BaseCommand command) {
for (Map.Entry<String, RootCommand> entry : command.registeredCommands.entrySet()) {
String jdaCommandName = entry.getKey().toLowerCase();
TestRootCommand jdaCommand = (TestRootCommand) entry.getValue();

This comment has been minimized.

Copy link
@MiniDigger

MiniDigger Mar 18, 2019

Contributor
Suggested change
TestRootCommand jdaCommand = (TestRootCommand) entry.getValue();
TestRootCommand rootCommand = (TestRootCommand) entry.getValue();
@aikar

aikar approved these changes Mar 23, 2019

@aikar aikar merged commit 1c056ce into aikar:master Mar 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.