Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getter for command conditions #225

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@JOO200
Copy link
Contributor

commented Jul 8, 2019

I created my own PaperCommandManager and want to share the completions, context resolver and conditions between multiple OwnCommandManagers. I have a static implementation which works fine except the command conditions.

Can we please change the command condition stuff here to use getters?

No breaking change and a nice thing for me.

JOO200

@chickeneer chickeneer merged commit d17055e into aikar:master Jul 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.