New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing hikari config property #8

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@sgdc3
Copy link
Contributor

sgdc3 commented Jan 8, 2019

HikariCP removed this option.

@aikar
Copy link
Owner

aikar left a comment

I'd rather keep this in for Hikari 2 users. Hikari 3 hasn't been properly vetted by me yet.

Can you do this in a way that keeps it for Hikari 2 and is there an alternative for hikari3?

@aikar

aikar approved these changes Jan 8, 2019

Copy link
Owner

aikar left a comment

per convo, this is actually default so not needed

@aikar aikar merged commit c7b46e5 into aikar:master Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sgdc3 sgdc3 deleted the sgdc3:patch-1 branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment