Basic commands for manipulating the aiken.toml #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit cleaner, as the 'cmd/new' had many on-the-fly functions which are better scoped inside this module. Plus, it plays nicely with the std::str::FromStr trait definition.
And refactor the 'new' command implementation.
This makes it easier to add new dependencies, without having to manually edit the `aiken.toml` file. The command is accessible via two different paths: - aiken deps add or simply - aiken add for this is quite common to find at the top-level of the command-line, and, we still want to keep commands for managing dependencies grouped under a command sub-group and not all at the top-level. So we're merely promoting that one for visibility.
Slightly more readable and self-explanatory.
There are restrictions regarding how modules are called, but given that packages are tight to repositories anyway; there's no way someone can publish and use an aiken package on 'aiken-lang' without being part of the organization. So the restriction on the command-line is pointless. Plus, it prevents us from using 'aiken-lang' as a placeholder name for tutorials.
rvcas
approved these changes
Jan 15, 2023
|
nice super cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257 & Closes #151.
📍 Move 'PackageName' and associated methods in its own module.
This is a bit cleaner, as the 'cmd/new' had many on-the-fly functions
which are better scoped inside this module.
Plus, it plays nicely with the std::str::FromStr trait definition.
📍 Also move some associated methods to the 'Config' module
And refactor the 'new' command implementation.
📍 Add new 'deps add' command
This makes it easier to add new dependencies, without having to
manually edit the
aiken.tomlfile.The command is accessible via two different paths:
or simply
for this is quite common to find at the top-level of the command-line,
and, we still want to keep commands for managing dependencies grouped
under a command sub-group and not all at the top-level. So we're
merely promoting that one for visibility.
📍 Rename sub-command 'deps' → 'packages'
Slightly more readable and self-explanatory.
📍 Add 'packages upgrade' command.