Skip to content

Commit

Permalink
Combined order summary to one subpart
Browse files Browse the repository at this point in the history
  • Loading branch information
@aimeos
aimeos committed Nov 20, 2016
1 parent ec9b732 commit fb1a999
Show file tree
Hide file tree
Showing 109 changed files with 1,756 additions and 10,950 deletions.
8 changes: 4 additions & 4 deletions client/html/build.xml
View file
@@ -1,30 +1,30 @@
<?xml version="1.0" encoding="UTF-8"?>

<project name="ai-client-html extension - HTML client" default="all">

<target name="test" description="Executes unit tests">
<echo msg="Executing unit tests" />
<delete file="tests/unittest.log" quiet="true" failonerror="false" />
<exec command="${bindir}phpunit -d memory_limit=-1 --include-path ${coredir} --configuration=phpunit.xml"
dir="tests" checkreturn="true" logoutput="true"/>
</target>

<target name="testperf" description="Executes performance tests">
<echo msg="Executing performance tests" />
<delete file="tests/unitperf.log" quiet="true" failonerror="false" />
<delete file="tests/client-html-jperf.xml" quiet="true" failonerror="false" />
<exec command="${bindir}phpunit -d memory_limit=-1 --include-path ${coredir} --configuration=phpunit-perf.xml --repeat 5"
dir="tests" checkreturn="true" logoutput="true"/>
</target>

<target name="coverage" description="Generates code coverage report">
<echo msg="Generating code coverage report" />
<delete file="tests/unittest.log" quiet="true" failonerror="false" />
<delete file="tests/coverage.xml" quiet="true" failonerror="false" />
<exec command="${bindir}phpunit -d memory_limit=-1 --include-path ${coredir} --configuration=phpunit-coverage.xml"
dir="tests" checkreturn="true" logoutput="true"/>
</target>

<target name="check" description="Executes code sniffer">
<echo msg="Executing code sniffer" />
<exec command="${bindir}phpcs -n --standard=${codestddir}/Metaways src tests/Client tests/Perf"
Expand Down
203 changes: 0 additions & 203 deletions client/html/src/Client/Html/Account/History/Order/Address/Standard.php
View file

This file was deleted.

2 comments on commit fb1a999

@faerietree
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Using a new summary base class has the benefit of reduced amount of code - I'm pretty sure that you have had more reasons for this change? (I just ask because I have customizations for many of these now merged subparts and hit some merge conflicts and can not find a reason in the commit message. No offense meant, it's quite doable to update to the no-subpart approach and I appreciate all your work a lot :-) - just curious.)

@aimeos
Copy link
Owner Author

@aimeos aimeos commented on fb1a999 Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agencies had problems integrating their HTML into the Aimeos subparts structure. This is now gone :-)

Please sign in to comment.