New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #51

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@matass
Contributor

matass commented Jun 3, 2017

Hey, @ain , @fkoester I think it would be useful to have an option to disable smartbanner by meta tag.

@matass matass force-pushed the matass:disable_smartbanner branch 2 times, most recently from 497bf6f to 7b4b924 Jun 3, 2017

@ain

This kind of implementation is actually not needed and therefore I'd limit this PR to documenting the already existing way to disable smartbanner:

<meta name="smartbanner:smartbanner-enabled" content="none">
README.md Outdated
```html
<meta name="smartbanner:smartbanner-disabled" content="true">
```

This comment has been minimized.

@ain

ain Jun 4, 2017

Owner

This README section here is the thing I'd keep in this PR to make use of it. I'd move it to be the last section in Advanced usage and rename to Hide the smartbanner completely.

@matass matass force-pushed the matass:disable_smartbanner branch from 30a992b to 3aaf8fe Jun 4, 2017

@matass matass changed the title from Init option to disable smart banner by meta tag to Update README Jun 4, 2017

@ain

ain approved these changes Jun 6, 2017

@ain ain merged commit f1a29f5 into ain:master Jun 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ain

This comment has been minimized.

Owner

ain commented Jun 6, 2017

Thanks @matass 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment