Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate README #51
Conversation
matass
force-pushed the
matass:disable_smartbanner
branch
2 times, most recently
from
497bf6f
to
7b4b924
Jun 3, 2017
ain
requested changes
Jun 4, 2017
This kind of implementation is actually not needed and therefore I'd limit this PR to documenting the already existing way to disable smartbanner:
<meta name="smartbanner:smartbanner-enabled" content="none">
README.md
Outdated
| ```html | ||
| <meta name="smartbanner:smartbanner-disabled" content="true"> | ||
| ``` | ||
This comment has been minimized.
This comment has been minimized.
ain
Jun 4, 2017
Owner
This README section here is the thing I'd keep in this PR to make use of it. I'd move it to be the last section in Advanced usage and rename to Hide the smartbanner completely.
matass
force-pushed the
matass:disable_smartbanner
branch
from
30a992b
to
3aaf8fe
Jun 4, 2017
matass
changed the title from
Init option to disable smart banner by meta tag
to
Update README
Jun 4, 2017
ain
merged commit f1a29f5
into
ain:master
Jun 6, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks @matass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
matass commentedJun 3, 2017
Hey, @ain , @fkoester I think it would be useful to have an option to disable smartbanner by meta tag.