Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse connection context manager #229

Merged
merged 1 commit into from
May 15, 2017
Merged

Conversation

argaen
Copy link
Member

@argaen argaen commented May 14, 2017

Closes #225

Only working for Redis. its not possible to do that with memcached connector yet.

@codecov-io
Copy link

codecov-io commented May 14, 2017

Codecov Report

Merging #229 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #229      +/-   ##
========================================
+ Coverage   98.94%    99%   +0.05%     
========================================
  Files          12     12              
  Lines         666    705      +39     
  Branches       74     76       +2     
========================================
+ Hits          659    698      +39     
  Misses          7      7
Impacted Files Coverage Δ
aiocache/backends/redis.py 100% <100%> (ø) ⬆️
aiocache/backends/memcached.py 100% <100%> (ø) ⬆️
aiocache/base.py 100% <100%> (ø) ⬆️
aiocache/backends/memory.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d919bd3...5acb35f. Read the comment docs.

@argaen argaen force-pushed the feature_#225/reuse_connections branch from edac299 to 5acb35f Compare May 14, 2017 17:06
@argaen argaen merged commit 5df519d into master May 15, 2017
@argaen argaen deleted the feature_#225/reuse_connections branch May 15, 2017 17:41
@argaen argaen restored the feature_#225/reuse_connections branch May 15, 2017 17:48
@argaen argaen deleted the feature_#225/reuse_connections branch May 25, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants