Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of aiohttp-bot. #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Initial commit of aiohttp-bot. #2

wants to merge 9 commits into from

Conversation

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Jul 5, 2019

Still need to work on adding more tests.

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.
@codecov
Copy link

@codecov codecov bot commented Jul 5, 2019

Codecov Report

No coverage uploaded for pull request base (master@06087d6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   87.30%           
=========================================
  Files             ?        9           
  Lines             ?      638           
  Branches          ?       46           
=========================================
  Hits              ?      557           
  Misses            ?       77           
  Partials          ?        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06087d6...9615fe0. Read the comment docs.

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jul 5, 2019

This pull request introduces 10 alerts when merging 798e0cc into 06087d6 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 3 for Module is imported with 'import' and 'import from'
  • 1 for Syntax error

Still need to work on adding more tests.
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jul 5, 2019

This pull request introduces 10 alerts when merging 155bff4 into 06087d6 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 3 for Module is imported with 'import' and 'import from'
  • 1 for Syntax error

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Jul 5, 2019

Cool!



@router.register("pull_request", action="closed")
async def delete_branch(event, gh, *args, **kwargs):
Copy link
Member

@webknjaz webknjaz Jul 6, 2019

There's https://github.com/apps/delete-merged-branch/ for this task. So there's no need to duplicate the effort.

@black-out
Copy link

@black-out black-out bot commented Jul 11, 2019

🐍🌚🤖 @Mariatta, I've formatted these files using black:

  • aiohttp_bot/main.py
  • aiohttp_bot/backport_pr.py
  • aiohttp_bot/stage.py
  • aiohttp_bot/status_change.py
  • aiohttp_bot/util.py
  • tests/test_backport_pr.py
  • tests/test_status_change.py
  • tests/test_util.py
    (I'm a bot 🤖)

@black-out black-out bot removed the black out label Jul 11, 2019
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jul 11, 2019

This pull request introduces 10 alerts when merging 9615fe0 into 06087d6 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 3 for Module is imported with 'import' and 'import from'
  • 1 for Syntax error

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants