New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with aiohttp 2.0.0.a1 #115

Closed
samuelcolvin opened this Issue Mar 15, 2017 · 13 comments

Comments

Projects
None yet
4 participants
@samuelcolvin
Copy link
Member

samuelcolvin commented Mar 15, 2017

ref aio-libs/aiohttp#1714

Traceback (most recent call last):
  File "/home/samuel/code/aiohttp-devtools/env/lib/python3.5/site-packages/aiohttp/web_protocol.py", line 417, in start
    resp = yield from self._request_handler(request)
  File "/home/samuel/code/aiohttp-devtools/env/lib/python3.5/site-packages/aiohttp/web.py", line 259, in _handle
    resp = yield from handler(request)
  File "/home/samuel/code/aiohttp-devtools/env/lib/python3.5/site-packages/aiohttp_debugtoolbar/middlewares.py", line 135, in toolbar_middleware
    yield from toolbar.process_response(request, response)
  File "/home/samuel/code/aiohttp-devtools/env/lib/python3.5/site-packages/aiohttp_debugtoolbar/toolbar.py", line 48, in process_response
    yield from panel.process_response(response)
  File "/home/samuel/code/aiohttp-devtools/env/lib/python3.5/site-packages/aiohttp_debugtoolbar/panels/request_vars.py", line 32, in process_response
    for k in sorted(request.POST)],
AttributeError: 'Request' object has no attribute 'POST'

Let me know if more details are required.

@jettify

This comment has been minimized.

Copy link
Member

jettify commented Mar 21, 2017

@samuelcolvin would you like to create PR with fix?

@doubledare704

This comment has been minimized.

Copy link
Contributor

doubledare704 commented Mar 22, 2017

Same with 2.0.1

@samuelcolvin

This comment has been minimized.

Copy link
Member

samuelcolvin commented Mar 22, 2017

yes, will try I'm pretty busy atm.

Perhaps someone could give me access to the repo?

@doubledare704

This comment has been minimized.

Copy link
Contributor

doubledare704 commented Mar 22, 2017

@samuelcolvin, fork and pull request)

@samuelcolvin

This comment has been minimized.

Copy link
Member

samuelcolvin commented Mar 22, 2017

Really?! I'd never heard of that.

If I'm managing aiohttp-devtools and have member access to aiohttp itself I would say it would make sense to have member access to aiohttp-debugtoolbar too.

@doubledare704

This comment has been minimized.

Copy link
Contributor

doubledare704 commented Mar 22, 2017

@samuelcolvin I saw you're contributing in aio-libs, but seems authors have not granted all access to you.

@jettify

This comment has been minimized.

Copy link
Member

jettify commented Mar 24, 2017

@samuelcolvin gave you access

@jettify

This comment has been minimized.

Copy link
Member

jettify commented Mar 24, 2017

sorry, missed your messages

@jettify

This comment has been minimized.

Copy link
Member

jettify commented Mar 24, 2017

i believe we can close this isseue

@jettify jettify closed this Mar 24, 2017

@cpwr

This comment has been minimized.

Copy link

cpwr commented May 3, 2017

still having the problem in
aiohttp==2.0.7
aiohttp-debugtoolbar==0.3.0

@doubledare704

This comment has been minimized.

Copy link
Contributor

doubledare704 commented May 4, 2017

@cpwr , because author made no update version for fixes to latest aio
try install from master, it has latest updates.

@jettify

This comment has been minimized.

Copy link
Member

jettify commented May 4, 2017

sorry for that, will do release tonight

@jettify

This comment has been minimized.

Copy link
Member

jettify commented May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment