From dd4a6e58d310f6705e46266e16bd95a92907ae54 Mon Sep 17 00:00:00 2001 From: Andrew Svetlov Date: Sat, 6 Aug 2016 12:56:10 +0300 Subject: [PATCH] Optimize cycle in CookieJar --- aiohttp/helpers.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/aiohttp/helpers.py b/aiohttp/helpers.py index 613b24e51cc..a46de492379 100644 --- a/aiohttp/helpers.py +++ b/aiohttp/helpers.py @@ -695,6 +695,8 @@ def filter_cookies(self, request_url): """Returns this jar's cookies filtered by their attributes.""" url_parsed = urlsplit(request_url) filtered = SimpleCookie() + hostname = url_parsed.hostname or "" + is_not_secure = url_parsed.scheme not in ("https", "wss") for name, cookie in self._cookies.items(): cookie_domain = cookie["domain"] @@ -704,8 +706,6 @@ def filter_cookies(self, request_url): dict.__setitem__(filtered, name, cookie) continue - hostname = url_parsed.hostname or "" - if not self._unsafe and is_ip_address(hostname): continue @@ -718,9 +718,7 @@ def filter_cookies(self, request_url): if not self._is_path_match(url_parsed.path, cookie["path"]): continue - is_secure = url_parsed.scheme in ("https", "wss") - - if cookie["secure"] and not is_secure: + if is_not_secure and cookie["secure"]: continue dict.__setitem__(filtered, name, cookie)