Support X-Forwarded-* and Forwarded implicitly, deprecate secure_proxy_ssl_header. #1134
Closed
Description
It's not obvious and the current doc is misleading: it proposes secure_proxy_ssl_header='X-Forwarded-Proto' but should do secure_proxy_ssl_header=('X-Forwarded-Proto', 'https').
Looks like @popravich made a mistake on documenting it by d4954ef
X-Forwarded-For,X-Forwarded-By, andX-Forwarded-Protoshould be supported. See the spec at http://docs.aws.amazon.com/elasticloadbalancing/latest/classic/x-forwarded-headers.htmlForwardedheader from RFC 7239 https://tools.ietf.org/html/rfc7239 should be supported as well.
The issue doesn't require a single Pull Request, most likely it should be several PRs, each for other aspect for sake of easy reviewing etc.
Until we'll remove deprecated secure_proxy_ssl_header support it should be processed first before all other rules.