Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestClient does not consume instance of yarl.URL #1389

Closed
imbolc opened this issue Nov 10, 2016 · 4 comments
Closed

TestClient does not consume instance of yarl.URL #1389

imbolc opened this issue Nov 10, 2016 · 4 comments
Labels

Comments

@imbolc
Copy link
Contributor

@imbolc imbolc commented Nov 10, 2016

I think it would be more consistent to allow it working with yarl.URL. Eg because reversing url by app.route returns it. But now it can't because of assert path.startswith('/') in TestServer.make_url() method here.

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 11, 2016

Would you provide a PR?

Loading

@imbolc
Copy link
Contributor Author

@imbolc imbolc commented Nov 11, 2016

Done :)

Loading

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 11, 2016

Fixed by #1391

Loading

@asvetlov asvetlov closed this Nov 11, 2016
@lock
Copy link

@lock lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

Loading

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants