New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestClient does not consume instance of yarl.URL #1389

Closed
imbolc opened this Issue Nov 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@imbolc
Contributor

imbolc commented Nov 10, 2016

I think it would be more consistent to allow it working with yarl.URL. Eg because reversing url by app.route returns it. But now it can't because of assert path.startswith('/') in TestServer.make_url() method here.

@asvetlov

This comment has been minimized.

Member

asvetlov commented Nov 11, 2016

Would you provide a PR?

@imbolc

This comment has been minimized.

Contributor

imbolc commented Nov 11, 2016

Done :)

@asvetlov

This comment has been minimized.

Member

asvetlov commented Nov 11, 2016

Fixed by #1391

@asvetlov asvetlov closed this Nov 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment