Change client connector's `limit` semantic

[fafhrd91]

Is limit useful in its current form? It seems confusing. Should it be just total number of connections?

[fafhrd91]

@asvetlov @kxepal @popravich ^^^

[kxepal]

How does it confusing and what's the alternative you want to propose?

[fafhrd91]

I would use as pool_size. Question is does anyone need current semantic of limit?

[kxepal]

pool_size sounds more clear than limit for me assuming the context where it applies.

[fafhrd91]

ok, here is mark limit as deprecated, add new pool_size attribute

[asvetlov]

Agree with limit deprecation but dislike pool_size name.
capacity, maxsize or size looks better for my taste.

[fafhrd91]

i like capacity

[asvetlov]

Cool!

[fafhrd91]

let's use maxsize, seems all aioxxx libraries use maxsize

[asvetlov]

+1 for capacity
+0 for maxsize
-1 for pool_size

[kxepal]

I share @asvetlov votes.

[fafhrd91]

ok, lets use "capacity"