Warnings should provide a stacklevel

[hynek]

Long story short

Warnings have useless frame/position information.

Expected behaviour

Warnings should point to my code so I know what to fix.

Actual behaviour

Warnings point to aiohttp’s lines where the warnings are raised (like aiohttp/helpers.py:129: DeprecationWarning: ClientSession.close() is a coroutine) which makes them rather useless. That’s because warnings.warn is called with the default stacklevel value of 1. It’s a rather unknown option but makes the warnings incredibly more useful. :) See also: https://docs.python.org/3/library/warnings.html#warnings.warn for an example.

[fafhrd91]

would you create PR?

[asvetlov]

@hynek I'm too lazy for pointing exact stack level for deprecation warnings.
Feel free to point on other places where the level is not correct.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.