New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest: add Access Logging option to show `X-Forwarded-For` #2123

Closed
harobed opened this Issue Jul 23, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@harobed

harobed commented Jul 23, 2017

Suggest: add Access Logging option to show X-Forwarded-For

Exemple %f option return X-Forwarded-For value or Remote IP-address if X-Forwarded-For don't exist.

@harobed harobed changed the title from Suggest: add Access Logging option to show `X_FORWARDED_HOST` to Suggest: add Access Logging option to show `X-Forwarded-For` Jul 23, 2017

harobed added a commit to harobed/aiohttp that referenced this issue Jul 23, 2017

@asvetlov

This comment has been minimized.

Member

asvetlov commented Jul 23, 2017

I suggest another change: pass request instead of message into AccessLogger.log (since aiohttp 2.0 web_protocol.RequestHandler always create a request instance.
In turn web.BaseRequest has req.host property, the property respects both Forwarded and X-FORWARDED-HOST headers.

@asvetlov

This comment has been minimized.

Member

asvetlov commented Jul 25, 2017

@harobed do you want to make a PR for implementing my proposal?

@harobed

This comment has been minimized.

harobed commented Jul 25, 2017

Yes, maybe this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment