Enable to remove "Content-Length: 0" for GET Request

[ga0]

Long story short

When I send GET request to some http server with the "Content-Length: 0" header, will cause a aiohttp.ServerDisconnectedError. If I remove this header, everything goes well.

I don't know why these server hate empty content-length header so much.

Expected behaviour

Some args to remove Content-Length if it is 0 and method is GET.

Steps to reproduce

You can test by using the comands below.

curl -v -H "Content-Length: 0" http://115.238.34.168

curl -v http://115.238.34.168 

Your environment

aiohttp: 2.0.7

OS & Python:

• macOS with Python 3.6.1
• CentOS7 with Python 3.4.5

[socketpair]

https://stackoverflow.com/questions/978061/http-get-with-request-body?answertab=active#tab-top

Content length mean presensce of a body, but with zero length. I prefer to close as "not a bug". No one http-client will send such requests. And sending body with GET-request difinitely signify a bug in client. RFC on HTTP is not strict enough, so current implementation of this case still leaves aiohttp RFC-compliant. Handling such reqests will not bring any benefits, just code bloat.

Why you want such functionality ?

Also please update aiohttp and re-test.

[ga0]

• Why you want such functionality ?

Because I found send GET request with "Content-Length: 0" header to some kind of servers will cause a bad request error.

• Also please update aiohttp and re-test.

I have tried aiohttp-2.2.5, still a "Content-Length: 0" in the request's header.

[socketpair]

Since it's not an security error, does not fix any real problem, does not add new functionality, I'm -3 for this issue.

[fafhrd91]

is it possible to disable content-length with skip_auto_headers?

[asvetlov]

Unfortunately no.

[fafhrd91]

I think we should support this use case

[asvetlov]

Agree.
I see two options:

1. Respect skip_auto_headers in Content-Length and Content-Encoding
2. Implement Introduce session.make_request() API #2019 and add a low level control for all HTTP request transformation details.

I prefer second bullet but it requires much more work.
Skipping mandatory fields like Content-Length in our prime API could make a mess (not 100% sure but I have bad guts feeling about this approach).

[socketpair]

Sorry, I did not catch original problem :(. As I think, Aiohttp has a bug. GET/HEAD/TRACE-requests hould not send content-length in any case.

[socketpair]

Please review #2191

[ga0]

I appreciate that you value this issue. 👍
I have to ask when this issue will be solved, or merged into the master branch? Do you have a plan?

I apologize for my poor English.
Thank you all you guys!

[asvetlov]

Fixed by #2167

[herono2010]

"Connection:Keep-Alive" and "Content-Length:0" should be together.