Client max size ignored on cloning web request object

[playpauseandstop]

Long story short

_client_max_size private attr not specified on cloning web_request.BaseRequest object.

Expected behaviour

When web.Application using custom client_max_size and in same time some middleware that cloned request, like https_middleware, there is still able to upload any file larger then 1Mb as default Request._client_max_size will be overwritten with value from Application.

Actual behaviour

When web.Application using custom client_max_size and in same time some middleware that cloned request, like https_middleware, there is unable to upload any file larger then 1Mb as default Request._client_max_size not overwritten with value from Application after request.clone call.

Steps to reproduce

• Enable https_middleware or any other middleware which clone request before passing to inner handler
• Run aiohttp under nginx with HTTPS support
• Upload any file larger then 1Mb
• Get ValueError on await request.post() or HTTPRequestEntityTooLarge on await request.read()

Your environment

• Python==3.6.3
• aiohttp==2.3.1

[asvetlov]

Fixed by #2386

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new