Build fails on Alpine when building in not a x86 architecture

[rgdoliveira]

Long story short

When trying to build aiohttp version 2.3.1 in Alpine (ppc64le and s390x architectures) the build fails at Alpine stripping part because it tries to strip "_http_parser.cpython-36m-x86_64-linux-gnu.so" shared object that is shipped in source code and fail in any architecture different from x86.

I guess the "_http_parser.cpython-36m-x86_64-linux-gnu.so" should not be shipped in the source code

Steps to reproduce

• Clone Alpine aports project
• build py3-aiohttp project (community/py3-aiohttp) with command abuild -r

Your environment

Alpine Linux 3.6.2 (ppc64le or s390x)

[asvetlov]

Good catch!
@webknjaz could you take a look? Or maybe @rgdoliveira could find a time for fix?
Checking build in Alpine would be nice but we should remove .so from tarball at least.

The PR should be done against 2.3 branch, I want make a new bugfix release.

[webknjaz]

@rgdoliveira @asvetlov I think, including smth like find -name *.so -type f -delete into our release process would fix this. Still I'll need some time for testing other approaches as well. For example, we could exclude it from manifest (https://github.com/aio-libs/aiohttp/blob/ca575f9/MANIFEST.in#L12-L18) or/and improve integration with setuptools-git, which seems to be added at some point (

aiohttp/requirements/ci.txt

Line 1 in 3b39eb3

setuptools-git==1.2

), but not configured completely.

[asvetlov]

Let's just add explicit exclusion rule in MANIFEST.in as hotfix.
We could return to discussion about setuptools-git usage later.
I don't feel we need it but maybe @webknjaz is true.
He was true many times regarding to our deployment process.

Anyway let's fix manifest and discuss future improvements later.

[RemiCardona]

Just a friendly poke to let you guys know I had to locally fix this issue by re-uploading 2.3.1 in my private pypi repo as 2.3.1+custom. This tar.gz was generated using python setup.py sdist in a fresh git clone and it works just great.

[asvetlov]

@RemiCardona thank for comment but we should fix our deployment process.

[asvetlov]

Fixed by 8622d6c
Please wait for bugfix release

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new