AioHTTPTestCase doesn't work with uvloop

[aptiko]

I can't tell whether this is a shortcoming of uvloop or a bug of aiohttp, but here it goes:

8e76a4a added this statement:

policy.set_child_watcher(watcher)

The problem is that uvloop's event policy subclasses asyncio.AbstractEventLoop, which doesn't implement set_child_watcher() (it raises NotImplementedError). Maybe it should subclass DefaultEventLoopPolicy, but I don't really know. In any case, attempting to run any AioHTTPTestCase with uvloop results in a NotImplementedError.

aiohttp 2.2 apparently doesn't have this problem.

[asvetlov]

Reported to uvloop team.
set_child_watcher is a part of AbstractEventLoopPolicy public API, uvloop should implement the method IMHO.
@1st1 ?

[1st1]

uvloop doesn't need watchers, it won't be able to use them at all. We can just implement an empty set_child_watcher, if that helps.

[asvetlov]

Please do.
Otherwise aiohttp need a check for uvloop policy which is a weird.

[1st1]

It won't happen right away, so for now I suggest you to just ignore NotImplementedError.

[asvetlov]

Makes sense.

[asvetlov]

Fixed by 2445993

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new