Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify stream classes #2555

Closed
4 tasks done
asvetlov opened this issue Nov 24, 2017 · 6 comments
Closed
4 tasks done

Simplify stream classes #2555

asvetlov opened this issue Nov 24, 2017 · 6 comments
Labels

Comments

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 24, 2017

  • drop ChunksQueue -- not used by aiohttp code
  • drop FlowControlChunksQueue -- not used by aiohttp code
  • Merge FlowControlStreamReader into StreamReader, drop FlowControlStreamReader. The reader without flow control is not used by aiohttp, FlowControlStreamReader is too long name. Getting rid of await super() calls may boost performance a little.
  • Add hysteresis to StreamReader to prevent flipping between paused and resumed states too often.
@kxepal
Copy link
Member

@kxepal kxepal commented Nov 24, 2017

FlowControlChuckQueue is useful when server emits item-per-chunk - that's quite handy to process. CouchDB does that for instance. Let me check if this approach is still actual.

Loading

@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Nov 24, 2017

If CouchDB needs FlowControlChuckQueue -- please copy the implementation into the project.
Supporting not used classes is a burden, you know.

Loading

@kxepal
Copy link
Member

@kxepal kxepal commented Nov 24, 2017

Not a problem, I know (: Probably, that even wouldn't be need after switching to ijson.

Loading

@kxepal
Copy link
Member

@kxepal kxepal commented Nov 24, 2017

Just wanted to describe the case when that flow was useful. Some else users eventually may use it as well.

Loading

@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Nov 25, 2017

Fixed by @2256

Loading

@lock
Copy link

@lock lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

Loading

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants