Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-aiohttp: compatibility with pytest v3.3.0 #2565

Closed
popravich opened this issue Nov 28, 2017 · 4 comments
Closed

pytest-aiohttp: compatibility with pytest v3.3.0 #2565

popravich opened this issue Nov 28, 2017 · 4 comments

Comments

@popravich
Copy link
Member

@popravich popravich commented Nov 28, 2017

Long story short

pytest-dev/pytest#2959
Fixture parameters are now immutable, pytest_plugin.py need to be updated

asvetlov added a commit that referenced this issue Nov 29, 2017
asvetlov added a commit that referenced this issue Nov 29, 2017
* Fix #2565: Fix compatibility with pytest 3.3+

* Polish docstring

* Fix coverage plugin

* Disable coverage blame
@asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 29, 2017

Fixed by #2573

@asvetlov asvetlov closed this Nov 29, 2017
@argaen
Copy link
Member

@argaen argaen commented Nov 30, 2017

Would it make sense to put code into pytest-aiohttp package? In cases like this, a new release of aiohttp is needed and not all the users are prepared to upgrade their aiohttp version just to use the latest pytest.

So for now, either users have to live with this until they upgrade or this could be backported to previous versions. IMO having this separated in pytest-aiohttp would make life easier

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 30, 2017

pytest-aiohttp is tightly coupled with aiohttp itself.
Keeping everything in the single code base simplifies testing aiohttp itself and checking that everything is working without problems.
Introduced pitfall requires a new pytest-aiohttp release though just to note people that problem is fixed.

Anyway pytest-aiohttp provides guarantee for the latest aiohttp only (the same policy as for aiohttp-session and other libs. Supporting a matrix of compatible versions is nightmare.

@lock
Copy link

@lock lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.