New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review pytest fixture names #2578

Closed
asvetlov opened this Issue Nov 30, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@asvetlov
Member

asvetlov commented Nov 30, 2017

Perhaps we need to add aiohttp_ prefix to all fixtures to prevent clashing with other libraries.
Existing names should be supported for sake of backward compatibility at least up to aiohttp 4.0.

Thoughts?

@fafhrd91

This comment has been minimized.

Member

fafhrd91 commented Nov 30, 2017

Those just tests and I think should be used by third party packages. It was a not logical change, upgrade is just find and replace. I’d add prefixes for 3.0

@asvetlov

This comment has been minimized.

Member

asvetlov commented Nov 30, 2017

The fixtures are used widespread, by aio-libs/aiohttp-* also.
I want to not break all these libs at moment of aiohttp 3.0 release.

@asvetlov asvetlov added this to the 3.0 milestone Dec 1, 2017

@asvetlov

This comment has been minimized.

Member

asvetlov commented Feb 9, 2018

Fixed by #2714

@asvetlov asvetlov closed this Feb 9, 2018

Latent-Logic added a commit to Latent-Logic/sir-bot-a-lot-2 that referenced this issue Nov 27, 2018

Fix aiohttp testing errors from aio-libs/aiohttp#2578
DeprecationWarning: Deprecated, use aiohttp_server fixture instead
DeprecationWarning: Deprecated, use aiohttp_client fixture instead

ovv added a commit to pyslackers/sir-bot-a-lot-2 that referenced this issue Nov 27, 2018

Slack shared secret message signing & aiohttp deprecation warnings (#30)
* Fix aiohttp testing errors from aio-libs/aiohttp#2578

DeprecationWarning: Deprecated, use aiohttp_server fixture instead
DeprecationWarning: Deprecated, use aiohttp_client fixture instead

* Support slack signing secrets for verification

Disables verification tokens if provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment