TestClient should expose app attribute

[thomaszdxsn]

Long story short

I wrote my first test today, use pytest-aiohttp, fixture: aiohttp_client.

I don't want to follow doc by use hardcode URL, I think it is not a good practical pattern. I want to use app.route[].url_for().

And I found it need long access chain. like cli.server.app.route[].url_for().with_query().

Maybe should expose app attribute/property in TestClient instance?

Expected behaviour

can access app in client by client.app.

Actual behaviour

must access client.server.app

[asvetlov]

I not sure.
The test client could be used for testing low-level server (https://docs.aiohttp.org/en/stable/web_lowlevel.html) where .app is not exist.

We can assign cli.app to None in this case but the behavior should be properly tested and documented.
If you want to make a fix for it -- you are welcome but please don't forget about low-level server testing.

[thomaszdxsn]

I will fix it on weekend

[asvetlov]

Cool!

[asvetlov]

Fixed by #2901

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new