Parse link headers (rfc5988)

[daniel-j-h]

See psf/requests#711 for context.

It would be great if aiohttp could parse link headers helping e.g. with pagination.

At the moment the ClientResponse has a headers attribute from which we can get the link header:

print(response.headers.get('Link'))

<https://example.com//page/3>; rel="next", <https://example.com/page/1>; rel="prev"

But it's of type str and not parsed. To use the url e.g. in the next rel (for pagination) users currently have to parse the link header string manually pulling out the url.

[asvetlov]

The attached issue has no design for the API, only many good wishes.

Would you elaborate your vision?

[daniel-j-h]

I'm not too deep into aiohttp - I was just using it for a small app and found out about the missing link header parsing; so I don't have clear real vision. The API I am familiar with is the requests API for link headers:

http://docs.python-requests.org/en/master/user/advanced/#link-headers

I think we need to make two calls here:

1. Should aiohttp do link header parsing or should users use an external library for it?
2. Should aiohttp replicate the requests API for link headers?

[asvetlov]

Well, supporting response.links['name'] sounds a good addition.

[asvetlov]

Any volunteer?

[hdk5]

I'll do it

[asvetlov]

Fixed by #2955

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new