multipart BodyPartReaderPayload filename wrong

[samuelcolvin]

aiohttp/aiohttp/multipart.py

Lines 446 to 448 in d8831f3

	if value.filename is not None:
	params['filename'] = value.name

Maybe I'm missing something, but this looks wrong, shouldn't it be value.filename?

[asvetlov]

I don't know.
@kxepal could you take a look?
I'm pretty busy now. Will have a time next week.

[samuelcolvin]

happy to correct and write unit tests, but I need to check I'm not missing something before I go any further.

[asvetlov]

For me it looks like a typo which should be fixed.

[kxepal]

Yeah. Definitely a copy-paste typo.

[samuelcolvin]

ok, I'm manic this week, but will try to provide a fix next week. I noticed it because this function doesn't have very good coverage, so will try to improve that too.

[asvetlov]

Cool!

[asvetlov]

Fixed by #3094

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new