Closed
Description
Long story short
Building the documentation fails on Windows
Expected behaviour
Successful documentation build
Actual behaviour
Attempts error with:
Configuration error:
There is a programable error in your configuration file:
Traceback (most recent call last):
File "c:\program files\python36\lib\site-packages\sphinx\config.py", line 161, in __init__
execfile_(filename, config)
File "c:\program files\python36\lib\site-packages\sphinx\util\pycompat.py", line 150, in execfile_
exec_(code, _globals)
File "conf.py", line 31, in <module>
fp.read(), re.M).groupdict()
AttributeError: 'NoneType' object has no attribute 'groupdict'
This is caused by usage of codecs.open, for which "no automatic conversion of '\n' is done on reading and writing." Therefore, "\r\n" is not converted to '\n', and the regex search fails with the carriage return and returns None.
Steps to reproduce
make doc
per https://docs.aiohttp.org/en/stable/contributing.html#documentation
Environment
Windows
Recommended Git line ending setting for Windows of "Checkout Windows-style, commit Unix-style", i.e. core.autocrlf set to true
Latest aiohttp cloned from repository