Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RouteTableDef can't register OPTIONS request handlers #4663

Closed
meetmangukiya opened this issue Mar 26, 2020 · 0 comments · Fixed by #4615
Closed

RouteTableDef can't register OPTIONS request handlers #4663

meetmangukiya opened this issue Mar 26, 2020 · 0 comments · Fixed by #4615
Labels
bug pr-merged

Comments

@meetmangukiya
Copy link
Contributor

🐞 Describe the bug
Currently it gives an AttributeError: 'RouteTableDef' object has no attribute 'options'

💡 To Reproduce

@route.options('/path')
def opts(request):
   ...

💡 Expected behavior
It should register decorated function as the OPTIONS request handler for that path
meetmangukiya added a commit to meetmangukiya/aiohttp that referenced this issue Mar 26, 2020
@meetmangukiya
web_routedef: Allow RouteTableDef to register options method handlers
62b445d 
Fixes aio-libs#4663
@meetmangukiya meetmangukiya mentioned this issue Mar 26, 2020
Merged
5 tasks
@helpr helpr bot added the pr-available label Mar 26, 2020
webknjaz added a commit that referenced this issue Mar 26, 2020
@meetmangukiya @webknjaz
Support registering OPTIONS HTTP method handlers via RouteTableDef
fa52a26 
PR #4615 by @meetmangukiya

Fixes #4663

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@helpr helpr bot added pr-merged and removed pr-available labels Mar 26, 2020
asvetlov pushed a commit that referenced this issue Oct 16, 2020
@meetmangukiya @webknjaz @asvetlov
Support registering OPTIONS HTTP method handlers via RouteTableDef
93363c9 
PR #4615 by @meetmangukiya

Fixes #4663

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
asvetlov pushed a commit that referenced this issue Nov 19, 2021
@meetmangukiya @webknjaz @asvetlov
Support registering OPTIONS HTTP method handlers via RouteTableDef
7a647d5 
PR #4615 by @meetmangukiya

Fixes #4663

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
asvetlov pushed a commit that referenced this issue Nov 19, 2021
@meetmangukiya @webknjaz @asvetlov
Support registering OPTIONS HTTP method handlers via RouteTableDef
4521ba3 
PR #4615 by @meetmangukiya

Fixes #4663

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@dabio dabio mentioned this issue Sep 22, 2022
Closed
renadvent added a commit to renadvent/renzen-bot that referenced this issue Jan 19, 2023
@dependabot @renadvent
Bump aiohttp from 3.7.4.post0 to 3.8.3 in /renzen (#75)
d0f17cc 
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.7.4.post0 to
3.8.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/aio-libs/aiohttp/releases">aiohttp's
releases</a>.</em></p>
<blockquote>
<h2>3.8.3</h2>
<p>.. attention::</p>
<p>This is the last :doc:<code>aiohttp &lt;index&gt;</code> release
tested under
Python 3.6. The 3.9 stream is dropping it from the CI and the
distribution package metadata.</p>
<h2>Bugfixes</h2>
<ul>
<li>
<p>Increased the upper boundary of the :doc:<code>multidict:index</code>
dependency
to allow for the version 6 -- by :user:<code>hugovk</code>.</p>
<p>It used to be limited below version 7 in :doc:<code>aiohttp
&lt;index&gt;</code> v3.8.1 but
was lowered in v3.8.2 via :pr:<code>6550</code> and never brought back,
causing
problems with dependency pins when upgrading. :doc:<code>aiohttp
&lt;index&gt;</code> v3.8.3
fixes that by recovering the original boundary of <code>&lt; 7</code>.
(<a
href="https://github-redirect.dependabot.com/aio-libs/aiohttp/issues/6950">#6950</a>)</p>
</li>
</ul>
<hr />
<h1>3.8.2 (2022-09-20, subsequently yanked on 2022-09-21)</h1>
<p>.. note::</p>
<p>This release has some compatibility fixes for Python 3.11 but it may
still have some quirks. Some tests are still flaky in the CI.</p>
<p>.. caution::</p>
<p>This release has been yanked from PyPI. Modern pip will not pick it
up automatically. The reason is that is has <code>multidict &lt;
6</code> set in
the distribution package metadata (see :pr:<code>6950</code>). Please,
use
<code>aiohttp ~= 3.8.3, != 3.8.1</code> instead, if you can.</p>
<h2>Bugfixes</h2>
<ul>
<li>Added support for registering :rfc:<code>OPTIONS
&lt;9110#OPTIONS&gt;</code>
HTTP method handlers via
:py:class:<code>~aiohttp.web.RouteTableDef</code>.
(<a
href="https://github-redirect.dependabot.com/aio-libs/aiohttp/issues/4663">#4663</a>)</li>
<li>Started supporting :rfc:<code>authority-form
&lt;9112#authority-form&gt;</code> and
:rfc:<code>absolute-form &lt;9112#absolute-form&gt;</code> URLs on the
server-side.
(<a
href="https://github-redirect.dependabot.com/aio-libs/aiohttp/issues/6227">#6227</a>)</li>
<li>Fixed Python 3.11 incompatibilities by using Cython 0.29.25.
(<a
href="https://github-redirect.dependabot.com/aio-libs/aiohttp/issues/6396">#6396</a>)</li>
<li>Extended the <code>sock</code> argument typing declaration of
the</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst">aiohttp's
changelog</a>.</em></p>
<blockquote>
<h1>3.8.3 (2022-09-21)</h1>
<p>.. attention::</p>
<p>This is the last :doc:<code>aiohttp &lt;index&gt;</code> release
tested under
Python 3.6. The 3.9 stream is dropping it from the CI and the
distribution package metadata.</p>
<h2>Bugfixes</h2>
<ul>
<li>
<p>Increased the upper boundary of the :doc:<code>multidict:index</code>
dependency
to allow for the version 6 -- by :user:<code>hugovk</code>.</p>
<p>It used to be limited below version 7 in :doc:<code>aiohttp
&lt;index&gt;</code> v3.8.1 but
was lowered in v3.8.2 via :pr:<code>6550</code> and never brought back,
causing
problems with dependency pins when upgrading. :doc:<code>aiohttp
&lt;index&gt;</code> v3.8.3
fixes that by recovering the original boundary of <code>&lt; 7</code>.
<code>[#6950](aio-libs/aiohttp#6950)
&lt;https://github.com/aio-libs/aiohttp/issues/6950&gt;</code>_</p>
</li>
</ul>
<hr />
<h1>3.8.2 (2022-09-20, subsequently yanked on 2022-09-21)</h1>
<h2>Bugfixes</h2>
<ul>
<li>
<p>Support registering OPTIONS HTTP method handlers via RouteTableDef.
<code>[#4663](aio-libs/aiohttp#4663)
&lt;https://github.com/aio-libs/aiohttp/issues/4663&gt;</code>_</p>
</li>
<li>
<p>Started supporting <code>authority-form</code> and
<code>absolute-form</code> URLs on the server-side.
<code>[#6227](aio-libs/aiohttp#6227)
&lt;https://github.com/aio-libs/aiohttp/issues/6227&gt;</code>_</p>
</li>
<li>
<p>Fix Python 3.11 alpha incompatibilities by using Cython 0.29.25
<code>[#6396](aio-libs/aiohttp#6396)
&lt;https://github.com/aio-libs/aiohttp/issues/6396&gt;</code>_</p>
</li>
<li>
<p>Remove a deprecated usage of pytest.warns(None)
<code>[#6663](aio-libs/aiohttp#6663)
&lt;https://github.com/aio-libs/aiohttp/issues/6663&gt;</code>_</p>
</li>
<li>
<p>Fix regression where <code>asyncio.CancelledError</code> occurs on
client disconnection.
<code>[#6719](aio-libs/aiohttp#6719)
&lt;https://github.com/aio-libs/aiohttp/issues/6719&gt;</code>_</p>
</li>
<li>
<p>Export :py:class:<code>~aiohttp.web.PrefixedSubAppResource</code>
under
:py:mod:<code>aiohttp.web</code> -- by
:user:<code>Dreamsorcerer</code>.</p>
<p>This fixes a regression introduced by :pr:<code>3469</code>.
<code>[#6889](aio-libs/aiohttp#6889)
&lt;https://github.com/aio-libs/aiohttp/issues/6889&gt;</code>_</p>
</li>
<li>
<p>Dropped the :class:<code>object</code> type possibility from
the :py:attr:<code>aiohttp.ClientSession.timeout</code>
property return type declaration.
<code>[#6917](aio-libs/aiohttp#6917)
&lt;https://github.com/aio-libs/aiohttp/issues/6917&gt;</code>_,</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/30b7a4e99677b4014dda2372504343bb05fc983e"><code>30b7a4e</code></a>
Add a yanking caution message to v3.8.2 changelog</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/18279443d4081a02585739d52c5822340068a13f"><code>1827944</code></a>
Stop including an empty changelog draft in Sphinx</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/58a4733a17f7d1a29ceda6d8cabd8d4204039038"><code>58a4733</code></a>
Mention that v3.8.2 has been yanked</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/13f50f949b8eca81c3809bc79f106e2336d49781"><code>13f50f9</code></a>
Move the Python 3.6 attention box to v3.8.3</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/cb20fd2be57f96bdef243a50d9cfd539ef13c095"><code>cb20fd2</code></a>
Bump aiohttp to v3.8.3</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/50203c42e51d820d7ea88d7faa019484c049c1e3"><code>50203c4</code></a>
Increase the upper boundary of the multidict dependency allowing v6</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/ee5e951244b98c407d9156b00b3bd3f445c092fa"><code>ee5e951</code></a>
Merge branch 'release/v3.8.2' into 3.8</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/3ef9cab654f1d2101d4e243cd5907966f9953f4c"><code>3ef9cab</code></a>
Bump the hardcoded version to v3.8.2.post0.dev0</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/99c8d0d7706153970bc1cbace8bdf4ab137783c7"><code>99c8d0d</code></a>
Brush up the changelog wording for v3.8.2</li>
<li><a
href="https://github.com/aio-libs/aiohttp/commit/a56b31cae75506e0640808567372359a159b1f96"><code>a56b31c</code></a>
Add a note about Python 3.6 in the changelog</li>
<li>Additional commits viewable in <a
href="https://github.com/aio-libs/aiohttp/compare/v3.7.4.post0...v3.8.3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=aiohttp&package-manager=pip&previous-version=3.7.4.post0&new-version=3.8.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renadvent <ericktiddle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support registering OPTIONS HTTP method handlers via RouteTableDef meetmangukiya/aiohttp
1 participant
@meetmangukiya