[TODO] Finish wiping the attrs usage

[webknjaz]

Describe the bug

Originally, @asvetlov intended to delete any use of attrs from aiohttp 4.0+ series via #5284. He dropped it from the runtime deps too.

But there are some places that still rely on attrs meaning that this will cause failures in runtime because of the missing dep. The tests currently succeed because attrs is listed as a test dep.

One place where it's used is

aiohttp/aiohttp/web_protocol.py

Line 23 in 4d58400

import attr

.

To Reproduce

pip install the recent master w/o the test deps and it should fail

Expected behavior

aiohttp shouldn't rely on deps not declared in the metadata.

Logs/tracebacks

N/A

Python Version

$ python --version

aiohttp Version

$ python -m pip show aiohttp

multidict Version

$ python -m pip show multidict

yarl Version

$ python -m pip show yarl

OS

N/A

Related component

Server

Additional context

No response

Code of Conduct

• I agree to follow the aio-libs Code of Conduct

[Dreamsorcerer]

A small side task here would be to add flake8-requirements, which will help ensure we don't have undeclared dependencies.

[RawatDevanshu]

A small side task here would be to add flake8-requirements, which will help ensure we don't have undeclared dependencies.

hey there, im new to git hub and beginner at coding too so.... can you please elaborate, thanks in advance

[Dreamsorcerer]

A small side task here would be to add flake8-requirements, which will help ensure we don't have undeclared dependencies.

hey there, im new to git hub and beginner at coding too so.... can you please elaborate, thanks in advance

Well, probably just need to add flake8-requirements to requirements/lint.txt (and add a line in .flake8 pointing to requirements/base.txt, similar to https://github.com/aio-libs/aiohttp-session/blob/master/.flake8#L23).
But, obviously it will need the attrs stuff removed first, otherwise it will give an error. There could be other things we haven't noticed as well.

[webknjaz]

Well, probably just need to add flake8-requirements to requirements/lint.txt

Nobody should manually edit pin constraint files managed by pip-tools. They should instead add direct deps to the corresponding .in files and regenerate the pins from that.