Skip to content

EofStream and websocket.receive_* functions #6800

Closed
@socketpair

Description

aiohttp 3.8.1

await websocket.receive_json() Will die with TypeError on WSMsgType.CLOSED.

#2784 is fixed, yes:

 async def __anext__(self) -> WSMessage:
        msg = await self.receive()
        if msg.type in (WSMsgType.CLOSE, WSMsgType.CLOSING, WSMsgType.CLOSED):
            raise StopAsyncIteration
        return msg

Yes, bug is fixed in iterator but NOT fixed for websocket.receive_* functions, like receive_json()

I would raise RuntimeError or so if corresponding message "type" (like bytes, str, or json) can not be received.

Metadata

Assignees

No one assigned

    Labels

    HacktoberfestWe think it's good for https://hacktoberfest.digitalocean.com/buggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions