Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate bare request(), get() and family for encouraging ClientSession usage #729

Closed
asvetlov opened this issue Jan 10, 2016 · 4 comments
Closed
Labels
Milestone

Comments

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 10, 2016

Recreating Connector on every request is a little expensive.
ClientSession allows connection utilization, it also supports keep-alives out-of-the box.

Unfortunately I see many examples of bare coroutines usage -- people are lazy :(

@gwillem
Copy link
Contributor

@gwillem gwillem commented Jan 10, 2016

Hi Andrew! IMHO most people will follow the basic examples without reading everything. Upper half of http://aiohttp.readthedocs.org/en/stable/client.html does not mention connectors.

Then again, people who care for performance are probably also the ones who do read the reference doc.

Loading

@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Jan 10, 2016

Would you update docs to emphasize ClientSession usage?

Loading

@asvetlov asvetlov added this to the 0.21 milestone Jan 13, 2016
@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Jan 13, 2016

Fixed by e194ede and e8b47f7

Loading

@lock
Copy link

@lock lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

Loading

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants