New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate bare request(), get() and family for encouraging ClientSession usage #729

Closed
asvetlov opened this Issue Jan 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@asvetlov
Member

asvetlov commented Jan 10, 2016

Recreating Connector on every request is a little expensive.
ClientSession allows connection utilization, it also supports keep-alives out-of-the box.

Unfortunately I see many examples of bare coroutines usage -- people are lazy :(

@gwillem

This comment has been minimized.

Contributor

gwillem commented Jan 10, 2016

Hi Andrew! IMHO most people will follow the basic examples without reading everything. Upper half of http://aiohttp.readthedocs.org/en/stable/client.html does not mention connectors.

Then again, people who care for performance are probably also the ones who do read the reference doc.

@asvetlov

This comment has been minimized.

Member

asvetlov commented Jan 10, 2016

Would you update docs to emphasize ClientSession usage?

@asvetlov asvetlov added this to the 0.21 milestone Jan 13, 2016

@asvetlov

This comment has been minimized.

Member

asvetlov commented Jan 13, 2016

Fixed by e194ede and e8b47f7

@asvetlov asvetlov closed this Jan 13, 2016

skeith added a commit to skeith/tmerc-cogs that referenced this issue Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment