Skip to content

Varying node versions & not using NPM clean install #8116

Closed
@steverep

Description

Is your feature request related to a problem?

For building llhttp, the docs, workflows, and Makefile all use npm install. This is not a particularly safe approach as it does not freeze the lock file. Instead, the npm ci command should be used.

In addition, I noticed that the current aiohttp CI builds with node 14, while llhttp itself just uses the default in GH hosted runners. Strongly recommend pinning this to the same version, and 14 is long out of maintenance. Version 18 is the maintenance LTS and 20 is the current LTS.

Describe the solution you'd like

  • All llhttp installs should use npm ci.
  • Consistently build llhttp with the same Node.js version (either current LTS or maintenance LTS).

Describe alternatives you've considered

n/a

Related component

Server, Client

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions