Enable cookie parsing for URLs which are IP-based, not DNS

[asvetlov]

Long story short

Working on aiohttp_session I've figured out that current behavior is not convenient for development and tests writing.

Expected behaviour

Don't ignore Set-Cookie from sites with IP address in URL

It's result of #799 PR

@panda73111 could you remind why you have added the filter?

As an option we can have StrictCookieJar class or strict=True CookieJar parameter with IP filter enabled but I believe default behavior should accept cookies from IP URLs.

@popravich what do you think?

[asvetlov]

@kxepal @1st1 @fafhrd91 and others, I'm asking for your opinions

[fafhrd91]

I don't have opinion on this topic. One note, would it be better to allow to use different implementation and provide cookies with filtering as an extra instead of adding more parameters?

[popravich]

same as @fafhrd91

[kxepal]

IP addresses in cookies are strongly discouraged by RFC. However, it's still allowed case per RFC-2109 and RFC-2965, but not for current one RFC-6265.

So it's ok to have that behaviour optional, but not by default.

[asvetlov]

@kxepal I don't understand you clean: are you suggest allowing ip addresses by default or forbidding?

[kxepal]

@asvetlov forbid as newest RFC defines and common guidelines defines. Enabling this is actually fallback to old RFCs where this is allowed, but discouraged, so I think that should be default state of things today.

[asvetlov]

Gotcha. Will publish bug fix release soon.

[asvetlov]

BTW what is good name for the class?
Both RelaxedCookieJar and CookieJarWithoutIPFiltering looks ugly.

[kxepal]

CookieJarDiscouraged

[asvetlov]

@kxepal are you kidding me?

[kxepal]

@asvetlov Sorry, but it was too seductive to not propose (:
Actually, why not to have a special option for CookieJar which controls that behaviour?

[asvetlov]

Fixed by aiohttp 0.22.2 release.
CookieJar(unsafe=True) disables IP address check

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.