Document streams #1150
Document streams #1150
Conversation
Current coverage is 98.30% (diff: 100%)@@ master #1150 diff @@
==========================================
Files 28 28
Lines 6489 6490 +1
Methods 0 0
Messages 0 0
Branches 1087 1087
==========================================
+ Hits 6378 6380 +2
+ Misses 61 60 -1
Partials 50 50
|
there was reason for inheritance. when i added inheritance asyncio did check |
There are two checks for |
It is opossite, asyncio does not accept anything except asyncio.StreamReader |
Got it. |
asyncio still checks for StreamReader instance in this change will break all installations. |
Yes, is has the check. |
Ok, I am fine with change Sent from my iPhone
|
@fafhrd91 thanks. Honestly I feel the current aiohttp state (parsers-readers-writers-DataQueue) is messy. Right now I have no proposal for fixing it but want to invest a time into. I'm considering all mentioned parts as very deep implementation details, e.g. if we'll drop DataQueue but incorporate processing into P.S. |
Explicitly document streaming API.
Fixes #1106
Also don't inherit
aiohttp.StreamReader
fromasyncio.StreamReader
.The inheritance makes a mess.
For example
asyncio.StreamReader
hasreaduntil()
method but calling it fromaiohttp.StreamReader
leads to crash because internal implementation differs.