Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix allow-head to include name on route #1737

Merged
merged 1 commit into from Mar 21, 2017

Conversation

@samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Mar 21, 2017

My original mistake on #1668, it's useful for the HEAD route to be named too, eg. here I'm checking the view name against a whitelist of "public views" before authentication.

Alternatively, routing could be entirely redesigned to allow "child" routes with duplicate names to their parents, but that sounds like overkill. 馃敧

@fafhrd91 fafhrd91 changed the base branch from master to 2.0 Mar 21, 2017
@fafhrd91 fafhrd91 changed the base branch from 2.0 to master Mar 21, 2017
@fafhrd91 fafhrd91 merged commit 0967611 into aio-libs:master Mar 21, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@samuelcolvin samuelcolvin deleted the samuelcolvin:fix-allow-head branch Mar 21, 2017
@lock
Copy link

@lock lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.