Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce amount of ssl related params in client API #2626

Closed
asvetlov opened this issue Dec 27, 2017 · 2 comments
Closed

Reduce amount of ssl related params in client API #2626

asvetlov opened this issue Dec 27, 2017 · 2 comments
Labels
client outdated
Milestone
3.0

Comments

@asvetlov
Copy link
Member

Now we have verify_ssl, fingerprint and ssl_context.

The proposal is replacing all of them with ssl.

  • if ssl is instance of ssl.SSLContext it is used as ssl_context
  • if ssl is False -- verify_ssl=False logic is applied
  • if ssl is instance of new Fingerprint class -- fingerprit check is applied

Existing params should be deprecated.
@asvetlov asvetlov added this to the 3.0 milestone Dec 27, 2017
@asvetlov asvetlov mentioned this issue Dec 27, 2017
Merged
@asvetlov
Copy link
Member Author

Fixed by #2628

@jeremy-hiatt jeremy-hiatt mentioned this issue Apr 5, 2019
Open
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
client outdated
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@asvetlov