Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PayloadWriter to StreamWriter #2654

Merged
merged 3 commits into from Jan 12, 2018
Merged

Conversation

@pfreixes
Copy link
Contributor

@pfreixes pfreixes commented Jan 11, 2018

What do these changes do?

Rename the PayloadWriter class to StreamWriter, having consistency with the reader side which has a class called StreamReader.

Are there changes in behavior for the user?

No

Related issue number

#2109

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
pfreixes added 2 commits Jan 11, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 11, 2018

Codecov Report

Merging #2654 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2654   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          39       39           
  Lines        7245     7245           
  Branches     1257     1257           
=======================================
  Hits         7099     7099           
  Misses         45       45           
  Partials      101      101
Impacted Files Coverage Δ
aiohttp/http.py 100% <ø> (ø) ⬆️
aiohttp/payload.py 98.74% <ø> (ø) ⬆️
aiohttp/http_writer.py 100% <100%> (ø) ⬆️
aiohttp/web_protocol.py 91.57% <100%> (ø) ⬆️
aiohttp/client_reqrep.py 97.36% <100%> (ø) ⬆️
aiohttp/web_fileresponse.py 97.87% <100%> (ø) ⬆️
aiohttp/abc.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c719e3e...108b8ad. Read the comment docs.

@asvetlov asvetlov merged commit b348e0f into master Jan 12, 2018
5 checks passed
5 checks passed
codecov/patch 100% of diff hit (target 97.98%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@asvetlov asvetlov deleted the rename_payloadwriter_streamwriter branch Jan 12, 2018
@asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 12, 2018

Thanks!

@lock
Copy link

@lock lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.