Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async write headers #2762

Merged
merged 4 commits into from Feb 26, 2018
Merged

Async write headers #2762

merged 4 commits into from Feb 26, 2018

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Feb 26, 2018

Make writer.write_headers() a coroutine

asvetlov added 4 commits Feb 26, 2018
@kxepal
Copy link
Member

@kxepal kxepal commented Feb 26, 2018

LGFM, but could you remind me, please, why all this need? What's the goal?

@webknjaz
Copy link
Member

@webknjaz webknjaz commented Feb 26, 2018

I guess it's related to #2743 (comment), right?

@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Feb 26, 2018

No, it is for #2698

@asvetlov
Copy link
Member Author

@asvetlov asvetlov commented Feb 26, 2018

After switching all writes to coroutines we can drop write buffers.

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 26, 2018

Codecov Report

Merging #2762 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
+ Coverage   97.97%   97.98%   +0.01%     
==========================================
  Files          39       39              
  Lines        7340     7339       -1     
  Branches     1285     1284       -1     
==========================================
  Hits         7191     7191              
  Misses         47       47              
+ Partials      102      101       -1
Impacted Files Coverage Δ
aiohttp/web_response.py 98.18% <100%> (ø) ⬆️
aiohttp/client_reqrep.py 97.39% <100%> (ø) ⬆️
aiohttp/test_utils.py 98.85% <100%> (+0.37%) ⬆️
aiohttp/http_writer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f38e14c...37ee8de. Read the comment docs.

@kxepal
Copy link
Member

@kxepal kxepal commented Feb 26, 2018

Cool! Thanks.

@kxepal
kxepal approved these changes Feb 26, 2018
@asvetlov asvetlov merged commit 0a94431 into master Feb 26, 2018
5 checks passed
5 checks passed
codecov/patch 100% of diff hit (target 97.97%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@asvetlov asvetlov deleted the async-write-headers branch Feb 26, 2018
@lock
Copy link

@lock lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.