Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets refactoring #2836

Merged
merged 10 commits into from Mar 15, 2018
Merged

Websockets refactoring #2836

merged 10 commits into from Mar 15, 2018

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Mar 15, 2018

A part of #2698

No Public API change

@asvetlov asvetlov added this to the 3.1 milestone Mar 15, 2018
asvetlov added 2 commits Mar 15, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 15, 2018

Codecov Report

Merging #2836 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
- Coverage   97.97%   97.97%   -0.01%     
==========================================
  Files          39       39              
  Lines        7445     7444       -1     
  Branches     1307     1307              
==========================================
- Hits         7294     7293       -1     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/http_websocket.py 98.6% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdf32c...cc12ed0. Read the comment docs.

@asvetlov asvetlov merged commit 89abb89 into master Mar 15, 2018
5 checks passed
5 checks passed
codecov/patch 100% of diff hit (target 97.97%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@asvetlov asvetlov deleted the ws-heartbeats branch Mar 15, 2018
@lock
Copy link

@lock lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.