Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract route definitions into a separate file #2876

Merged
merged 2 commits into from
Mar 25, 2018
Merged

Conversation

asvetlov
Copy link
Member

A part of #2766 reorganization
web_urldispatcher.py is very huge.

Route definitions could be extracted into a separate web_routedef.py easy.
No tests are broken.
Anyway these names are part of aiohttp.web namespace, importing them directly from aiohttp.web_urldispatcher is an error.

@codecov-io
Copy link

codecov-io commented Mar 25, 2018

Codecov Report

Merging #2876 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
+ Coverage   97.97%   97.97%   +<.01%     
==========================================
  Files          39       40       +1     
  Lines        7464     7469       +5     
  Branches     1310     1310              
==========================================
+ Hits         7313     7318       +5     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/web.py 98.8% <100%> (+0.01%) ⬆️
aiohttp/web_urldispatcher.py 99.1% <100%> (-0.12%) ⬇️
aiohttp/web_routedef.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b8921...cf0f02a. Read the comment docs.

@asvetlov asvetlov merged commit cf78b63 into master Mar 25, 2018
@asvetlov asvetlov deleted the extract-routedefs branch March 25, 2018 15:26
@asvetlov asvetlov added this to the 3.2 milestone Mar 25, 2018
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants