Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gunicorn logging documentation #2921

Merged
merged 4 commits into from
Apr 17, 2018
Merged

Improve Gunicorn logging documentation #2921

merged 4 commits into from
Apr 17, 2018

Conversation

crisidev
Copy link
Contributor

@crisidev crisidev commented Apr 6, 2018

What do these changes do?

Improve Gunicorn logging documentation.

Are there changes in behavior for the user?

No.

Related issue number

#2916

@crisidev
Copy link
Contributor Author

crisidev commented Apr 6, 2018

Travis is failing because I made an error in the docs. Working on a fix.

@asvetlov
Copy link
Member

asvetlov commented Apr 6, 2018

Still fails :(

@crisidev
Copy link
Contributor Author

Interesting.. On my laptop it builds fine.. I will address this as soon as I have some time. Sorry about that :D

@asvetlov
Copy link
Member

Warning, treated as error:
/home/travis/build/aio-libs/aiohttp/docs/deployment.rst:283:undefined label: gunicorn-access-logs (if the link has no caption the label must precede a section header)

@crisidev
Copy link
Contributor Author

I should have fixed the issue :) I am quite new to RST with anchors. You may want to squash the commits into one.

@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #2921 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
+ Coverage   97.98%   97.99%   +<.01%     
==========================================
  Files          40       40              
  Lines        7511     7513       +2     
  Branches     1318     1318              
==========================================
+ Hits         7360     7362       +2     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/connector.py 96.82% <0%> (ø) ⬆️
aiohttp/web_protocol.py 91.86% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c525c...9158664. Read the comment docs.

@asvetlov asvetlov merged commit af0994f into aio-libs:master Apr 17, 2018
@asvetlov
Copy link
Member

Thanks

@crisidev
Copy link
Contributor Author

Sweet!

thehesiod pushed a commit to thehesiod-forks/aiohttp that referenced this pull request Apr 26, 2018
* Improve gunicorn logging documentation

* Fix spelling error in logging documentation

* Fix anchor linking between different files

* Create 2921.doc
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants