Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate app.make_handler() #2938

Merged
merged 5 commits into from
Apr 19, 2018
Merged

Deprecate app.make_handler() #2938

merged 5 commits into from
Apr 19, 2018

Conversation

xstrengthofonex
Copy link
Contributor

@xstrengthofonex xstrengthofonex commented Apr 14, 2018 •
edited by asvetlov
Loading

What do these changes do?

Deprecate the use of Application.make_handler()

Are there changes in behavior for the user?

Related issue number

#2875

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Apr 14, 2018 •
edited
Loading

Codecov Report

Merging #2938 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2938      +/-   ##
==========================================
+ Coverage   97.99%   97.99%   +<.01%     
==========================================
  Files          40       40              
  Lines        7513     7523      +10     
  Branches     1318     1318              
==========================================
+ Hits         7362     7372      +10     
  Misses         48       48              
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/web_runner.py 100% <100%> (ø) ⬆️
aiohttp/web_app.py 99.09% <100%> (+0.01%) ⬆️
aiohttp/web_fileresponse.py 98.01% <0%> (ø) ⬆️
aiohttp/client_reqrep.py 97.27% <0%> (+0.02%) ⬆️
aiohttp/client_exceptions.py 95.65% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a6782...281a0b9. Read the comment docs.

asvetlov
asvetlov requested changes Apr 17, 2018
View reviewed changes
aiohttp/web_app.py Outdated
loop=None,
access_log_class=AccessLogger,
**kwargs):
warnings.warn("@make_handler is deprecated",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace @make_handler with Application.make_handler(...) and add a test for making sure that deprecation warning is raised.

docs/logging.rst Outdated
@@ -32,6 +32,7 @@ Access log by default is switched on and uses ``'aiohttp.access'``
logger name.

The log may be controlled by :meth:`aiohttp.web.Application.make_handler` call.
.. deprecated:: 3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the deprecation but replace aiohttp.web.Application.make_handler with aiohttp.web.AppRunner / aiohttp.web.run_app()

docs/logging.rst Outdated
@@ -123,7 +124,7 @@ The log is enabled by default.
To use different logger name please specify *logger* parameter
(:class:`logging.Logger` instance) on performing
:meth:`aiohttp.web.Application.make_handler` call.

.. deprecated:: 3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same

@asvetlov asvetlov merged commit 708d1f0 into aio-libs:master Apr 19, 2018
@asvetlov
Copy link
Member

Thanks!

@asvetlov asvetlov added this to the 3.2 milestone Apr 19, 2018
@asvetlov asvetlov mentioned this pull request Apr 19, 2018
Closed
thehesiod pushed a commit to thehesiod-forks/aiohttp that referenced this pull request Apr 26, 2018
@xstrengthofonex @thehesiod
Deprecate app.make_handler() (aio-libs#2938)
45dc95f
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xstrengthofonex @codecov-io @asvetlov