Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply assertions in debug mode only #2966

Merged
merged 7 commits into from
May 1, 2018
Merged

Apply assertions in debug mode only #2966

merged 7 commits into from
May 1, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Apr 28, 2018

A work on #2859

@codecov-io
Copy link

codecov-io commented Apr 28, 2018

Codecov Report

Merging #2966 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
+ Coverage   97.98%   97.98%   +<.01%     
==========================================
  Files          40       40              
  Lines        7592     7594       +2     
  Branches     1323     1325       +2     
==========================================
+ Hits         7439     7441       +2     
  Misses         51       51              
  Partials      102      102
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.1% <100%> (ø) ⬆️
aiohttp/web_app.py 99.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba7bf1...57e11f6. Read the comment docs.

@asvetlov asvetlov merged commit bcd6fa4 into master May 1, 2018
@asvetlov asvetlov deleted the debug-asserts branch May 1, 2018 13:22
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants