Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dead Connection.detach() and Connection.writer #3358

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Conversation

asvetlov
Copy link
Member

Both methods were broken for more than 2 years.

Both methods was broken for more than 2 years.
@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #3358 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3358      +/-   ##
==========================================
- Coverage   98.06%   98.03%   -0.04%     
==========================================
  Files          44       44              
  Lines        8341     8334       -7     
  Branches     1370     1369       -1     
==========================================
- Hits         8180     8170      -10     
- Misses         66       68       +2     
- Partials       95       96       +1
Impacted Files Coverage Δ
aiohttp/connector.py 98.16% <ø> (-0.03%) ⬇️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.49% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c90cf...9c6330a. Read the comment docs.

@webknjaz webknjaz merged commit a06ad98 into master Oct 23, 2018
@asvetlov asvetlov deleted the drop-dead-code branch October 24, 2018 09:27
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants