Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClientSession slot-based class #3463

Merged
merged 2 commits into from
Dec 27, 2018
Merged

Make ClientSession slot-based class #3463

merged 2 commits into from
Dec 27, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Dec 25, 2018

Convert debug-mode warning about a wild session modification into a strict error.

@codecov-io
Copy link

codecov-io commented Dec 25, 2018

Codecov Report

Merging #3463 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3463   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files          44       44           
  Lines        8558     8558           
  Branches     1383     1383           
=======================================
  Hits         8383     8383           
  Misses         72       72           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c45b4e...52264c4. Read the comment docs.

@asvetlov asvetlov merged commit 2a346da into master Dec 27, 2018
@asvetlov asvetlov deleted the client-session-slots branch December 27, 2018 19:36
@lock
Copy link

lock bot commented Dec 27, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Dec 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants