Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor web_protocol #3540

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Refactor web_protocol #3540

merged 2 commits into from
Jan 15, 2019

Conversation

asvetlov
Copy link
Member

  • Drop dead code
  • Make sanity check working in release mode

@codecov-io
Copy link

Codecov Report

Merging #3540 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3540      +/-   ##
==========================================
+ Coverage   97.88%   97.94%   +0.06%     
==========================================
  Files          43       43              
  Lines        8585     8608      +23     
  Branches     1388     1400      +12     
==========================================
+ Hits         8403     8431      +28     
+ Misses         75       74       -1     
+ Partials      107      103       -4
Impacted Files Coverage Δ
aiohttp/web_exceptions.py 100% <ø> (ø) ⬆️
aiohttp/web_protocol.py 92.64% <100%> (+0.94%) ⬆️
aiohttp/client_reqrep.py 97.84% <0%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e60406...40839a8. Read the comment docs.

@asvetlov asvetlov merged commit 18a64b2 into master Jan 15, 2019
@asvetlov asvetlov deleted the web-protocol-cleanup branch January 15, 2019 23:10
@lock
Copy link

lock bot commented Jan 16, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants